From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: ABI/API breakage Date: Mon, 20 Jul 2009 16:37:39 +0200 Message-ID: <200907201637.40053.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "dcm@mccr.org" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Monday 20 July 2009 16:15:31 Keir Fraser wrote: > On 20/07/2009 13:44, "Christoph Egger" wrote: > > Hi! > > > > Changeset 19639 changed the ABI/API w/o taking care about backward > > compatibility. > > This breaks the xen build in upstream qemu in file hw/xen_domainbuild.c > > Is xc_linux_build() the only problematic function? That one could be > reverted easily enough. Actually superpages should really just get bunged > in 'struct xc_dom_image' I think. Then the interface for all domain build= er > functions reverts to what it was previously. =46or qemu, xc_linux_build() is the only one problematic function. =46rom the engineering point-of-view, your proposal to collapse superpages into 'struct xc_dom_image' is the best solution. Christoph =2D-=20 =2D--to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632