All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU
Date: Mon, 20 Jul 2009 17:42:20 +0200	[thread overview]
Message-ID: <20090720174220.1800dcaa@surf> (raw)
In-Reply-To: <20090717194143.083AC832E416@gemini.denx.de>

Le Fri, 17 Jul 2009 21:41:43 +0200,
Wolfgang Denk <wd@denx.de> a ?crit :

> Entries to maintainers is missing.

Yes, it was missing in the initial version of my patch, but further
versions got it added, thanks to other people review.

> > +int dram_init(void)
> > +{
> > +	gd->bd->bi_dram[0].start = PHYS_SDRAM;
> > +	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
> > +	return 0;
> > +}
> 
> Any specific reason for not using autosizing and testing via
> get_ram_size() ?

The initial reason is that the code for this board is taken from the
Atmel boards code, which doesn't use get_ram_size(). However, my board
has a fixed RAM size, so in that case, is it still useful to use
get_ram_size() ?

> Line too long. Please fix globally.

Thanks, will do.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2009-07-20 15:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 12:07 [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU Thomas Petazzoni
2009-07-08 21:42 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-15 14:35   ` Thomas Petazzoni
2009-07-15 14:51     ` Peter Tyser
2009-07-16 11:39       ` Thomas Petazzoni
2009-07-16 14:52         ` Peter Tyser
2009-07-20 15:40           ` Thomas Petazzoni
2009-07-20 15:51             ` Peter Tyser
2009-07-17 19:41     ` Wolfgang Denk
2009-07-20 15:42       ` Thomas Petazzoni [this message]
2009-07-20 21:11         ` Wolfgang Denk
2009-07-22 15:30 ` Thomas Petazzoni
2009-07-22 15:57   ` Peter Tyser
2009-07-22 16:04     ` Thomas Petazzoni
2009-07-22 16:10       ` Peter Tyser
2009-07-22 16:05     ` Albin Tonnerre
2009-07-23 22:35   ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 22:45     ` Wolfgang Denk
2009-07-23 22:53       ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-24  5:38         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090720174220.1800dcaa@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.