From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: ABI/API breakage Date: Mon, 20 Jul 2009 17:56:35 +0200 Message-ID: <200907201756.35873.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: "dcm@mccr.org" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Monday 20 July 2009 16:49:01 Keir Fraser wrote: > On 20/07/2009 15:37, "Christoph Egger" wrote: > >> Is xc_linux_build() the only problematic function? That one could be > >> reverted easily enough. Actually superpages should really just get > >> bunged in 'struct xc_dom_image' I think. Then the interface for all > >> domain builder functions reverts to what it was previously. > > > > For qemu, xc_linux_build() is the only one problematic function. > > From the engineering point-of-view, your proposal to collapse superpages > > into 'struct xc_dom_image' is the best solution. > > Try changeset 19963. Confirmed. This unbreaks build of qemu. Tnx for fixing. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632