[Ocfs2-devel] [PATCH 1/1] adds mlogs to aops.c

[Joel Becker <Joel.Becker@oracle.com>]

On Mon, Jul 13, 2009 at 11:37:39AM +0800, Wengang Wang wrote:
> @@ -217,11 +219,16 @@ int ocfs2_read_inline_data(struct inode *inode, struct page *page,
>  	void *kaddr;
>  	loff_t size;
>  	struct ocfs2_dinode *di = (struct ocfs2_dinode *)di_bh->b_data;
> +	int status = 0;
> +
> +	mlog_entry("(%llu, %lu, %llu)\n", OCFS2_I(inode)->ip_blkno,
> +		   page->index, (unsigned long long)di_bh->b_blocknr);

	You're printing OCFS2_I(inode)->ip_blkno with %llu but not
casting it to unsigned long long.  It needs those casts for stricter
platforms.  Make sure all your u64 mlog additions have the cast.

Joel

-- 

"I inject pure kryptonite into my brain.
 It improves my kung fu, and it eases the pain."


Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127