From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] tools: use C99 __VA_ARGS__ Date: Tue, 21 Jul 2009 15:47:20 +0200 Message-ID: <200907211547.20773.Christoph.Egger@amd.com> References: <200907211501.15045.Christoph.Egger@amd.com> <19045.49654.819861.134478@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19045.49654.819861.134478@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org On Tuesday 21 July 2009 15:26:14 Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"): > > Attached patch switches tools to consistently use C99 __VA_ARGS__. > > What is the benefit of this ? Consistency in the whole tree in combination with two other patches (xen-kernel and minios) which I have not yet submitted. > Xen requires GCC and the GCC variable > argument list extension has been around forever, That's not a reason to stick on old things. > so it doesn't seem to aid portability. No, not in this case. But the other patch for the xen-kernel touches the public headers. AFAIK the public headers should follow the standard. > The GCC syntax is considerably prettier than the C99 one. This is subjective. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632