From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] tools: use C99 __VA_ARGS__ Date: Tue, 21 Jul 2009 16:26:35 +0200 Message-ID: <200907211626.35657.Christoph.Egger@amd.com> References: <200907211501.15045.Christoph.Egger@amd.com> <200907211547.20773.Christoph.Egger@amd.com> <19045.51136.22397.373381@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_bAdZKb4FX34un4a" Return-path: In-Reply-To: <19045.51136.22397.373381@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --Boundary-00=_bAdZKb4FX34un4a Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tuesday 21 July 2009 15:50:56 Ian Jackson wrote: > Christoph Egger writes ("Re: [Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"): > > On Tuesday 21 July 2009 15:26:14 Ian Jackson wrote: > > > Christoph Egger writes ("[Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"): > > > > Attached patch switches tools to consistently use C99 __VA_ARGS__. > > > > > > What is the benefit of this ? > > > > Consistency in the whole tree in combination with two other patches > > (xen-kernel and minios) which I have not yet submitted. > > Umm, so what's the benefit of the whole patchset ? Consistency. :) > > > Xen requires GCC and the GCC variable > > > argument list extension has been around forever, > > > > That's not a reason to stick on old things. > > Neither is there apparently any reason to change. > > > > so it doesn't seem to aid portability. > > > > No, not in this case. > > > > But the other patch for the xen-kernel touches > > the public headers. > > AFAIK the public headers should follow the standard. > > Do the public headers currently work with other compilers ? Yes, Sun compiler. > There is an argument for using the standard syntax there to make it easier > for kernels compiled with non-GCC compilers to provide Xen guest support. I have attached the part of the xen-kernel patch which touches the public headers only. I suppose, Sun didn't use acm or they would have noticed it. Signed-off-by: Christoph Egger Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --Boundary-00=_bAdZKb4FX34un4a Content-Type: text/x-diff; charset="iso-8859-1"; name="xen_public_varargs.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_public_varargs.diff" diff -r 534d3716bbbe xen/include/public/xsm/acm.h --- a/xen/include/public/xsm/acm.h Tue Jul 21 12:06:52 2009 +0100 +++ b/xen/include/public/xsm/acm.h Tue Jul 21 16:21:34 2009 +0200 @@ -35,9 +35,9 @@ /* #define ACM_DEBUG */ #ifdef ACM_DEBUG -# define printkd(fmt, args...) printk(fmt,## args) +# define printkd(fmt, ...) printk(fmt, ##__VA_ARGS__) #else -# define printkd(fmt, args...) +# define printkd(fmt, ...) #endif /* default ssid reference value if not supplied */ --Boundary-00=_bAdZKb4FX34un4a Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_bAdZKb4FX34un4a--