From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 02/11] Unregister ack notifier callback on PIT freeing. Date: Tue, 21 Jul 2009 20:30:44 +0300 Message-ID: <20090721173044.GE1424@redhat.com> References: <1247753019-11412-1-git-send-email-gleb@redhat.com> <1247753019-11412-3-git-send-email-gleb@redhat.com> <20090721171643.GB6959@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33930 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbZGURaq (ORCPT ); Tue, 21 Jul 2009 13:30:46 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6LHUkDa013959 for ; Tue, 21 Jul 2009 13:30:46 -0400 Content-Disposition: inline In-Reply-To: <20090721171643.GB6959@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 21, 2009 at 02:16:43PM -0300, Marcelo Tosatti wrote: > On Thu, Jul 16, 2009 at 05:03:30PM +0300, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > > arch/x86/kvm/i8254.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c > > index 137e548..472653c 100644 > > --- a/arch/x86/kvm/i8254.c > > +++ b/arch/x86/kvm/i8254.c > > @@ -672,6 +672,8 @@ void kvm_free_pit(struct kvm *kvm) > > if (kvm->arch.vpit) { > > kvm_unregister_irq_mask_notifier(kvm, 0, > > &kvm->arch.vpit->mask_notifier); > > + kvm_unregister_irq_ack_notifier(kvm, > > + &kvm->arch.vpit->pit_state.irq_ack_notifier); > > mutex_lock(&kvm->arch.vpit->pit_state.lock); > > timer = &kvm->arch.vpit->pit_state.pit_timer.timer; > > hrtimer_cancel(timer); > > Applied this one. > > I suppose you're reworking the lockless patchset to include the PIC irq > ack changes? (as discussed the pic_unlock trick with vcpu_kick is not > necessary anymore etc). > Fixed all of this already. Want them as separate patch series? I did them on my irq branch but they are good for master too. > Just please if you have any fixes, send them separately so backporting > to -stable is easier. > -- Gleb.