All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valerie Aurora <vaurora@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: Theodore Tso <tytso@mit.edu>, Ric Wheeler <rwheeler@redhat.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"Stephen C. Tweedie" <sct@redhat.com>,
	Eric Sandeen <esandeen@redhat.com>,
	Chris Mason <chris.mason@oracle.com>,
	Josef Bacik <jbacik@redhat.com>, Mingming Cao <cmm@us.ibm.com>
Subject: Re: ext3 default journal mode
Date: Tue, 21 Jul 2009 13:44:52 -0400	[thread overview]
Message-ID: <20090721174452.GB28383@shell> (raw)
In-Reply-To: <20090720233620.GC4231@webber.adilger.int>

On Mon, Jul 20, 2009 at 05:36:20PM -0600, Andreas Dilger wrote:
> On Jul 20, 2009  19:04 -0400, Valerie Aurora wrote:
> > I think it's extremely accurate and detailed, but too long - people's
> > brains turn off after about the 15th line or so.  Here's an attempt to
> > distill your description down and refer out to another document (which
> > one?) for people who want to learn more.
> > 
> > (Sorry for the whitespace damage.)
> > 
> > -VAL
> > 
> >  config EXT3_DEFAULTS_TO_ORDERED
> >  	bool "Default to 'data=ordered' in ext3"
> >  	depends on EXT3_FS
> >  	help
> > 
> >           If the mount options for an ext3 filesystem do not
> >           include a journal mode, mount it in "data=ordered" mode.
> 
> I would make this a bit more clear:
> 
>             This option sets the default journal mode for ext3 filesystems
> 	    which do not explicitly specify it in /etc/fstab or at mount
> 	    time.  It is always possible to set the journal mode for each
> 	    filesystem independently with "data=writeback", "data=ordered",
> 	    or "data=journal" mount options.
> 
> >           The journal mode options for ext3 have different tradeoffs
> >           between when data is guaranteed to be on disk and
> >           performance.  Many applications assume "data=ordered"
> >           semantics and may lose, destroy, or reveal other user's data
> >           in other journal modes.  However, "data=ordered" mode can
> >           also result in major performance problems, including long
> >           delays before an fsync() call returns.  For details, see:
> 
> I think the "... lose, destroy, ..." part is confusing, as it mentions
> "data=ordered" first and it isn't until the end of the sentence that
> it is clear that "lose, destroy, ..." does not apply to data=ordered.
> Also "data=journal" also does not apply in this case, only "data=writeback"
> so we may as well call that out explicitly.
> 
>             ...  Many applications do not explicitly sync data and assume
> 	    "data=ordered" mode.  Saying 'N' here will use "data=writeback"
> 	    as the default for all ext3 filesystems, and may result in
> 	    files with no data, or garbage data from deleted files,
> 	    which is a security risk on a multi-user system.  However, ...

Good points.  I think Ted's rewrite addresses most of them, what do you think?

-VAL

  reply	other threads:[~2009-07-21 17:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-20  2:50 ext3 default journal mode Ric Wheeler
2009-07-20 14:18 ` Chris Mason
2009-07-20 14:32   ` Ric Wheeler
2009-07-20 21:29 ` Theodore Tso
2009-07-20 21:33   ` Ric Wheeler
2009-07-20 23:04   ` Valerie Aurora
2009-07-20 23:36     ` Andreas Dilger
2009-07-21 17:44       ` Valerie Aurora [this message]
2009-07-21  2:00     ` Theodore Tso
2009-07-21 17:44       ` Valerie Aurora
2009-07-23 13:14         ` Ric Wheeler
2009-07-20 22:58 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721174452.GB28383@shell \
    --to=vaurora@redhat.com \
    --cc=adilger@sun.com \
    --cc=chris.mason@oracle.com \
    --cc=cmm@us.ibm.com \
    --cc=esandeen@redhat.com \
    --cc=jbacik@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=rwheeler@redhat.com \
    --cc=sct@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.