From: Christoph Hellwig <hch@infradead.org>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org,
Hans-Joachim Picht <hans@linux.vnet.ibm.com>,
pm list <linux-pm@lists.linux-foundation.org>,
Arnd Schneider <arnd@de.ibm.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: PM/hibernate swapfile regression
Date: Tue, 21 Jul 2009 17:55:36 -0400 [thread overview]
Message-ID: <20090721215536.GA9502@infradead.org> (raw)
In-Reply-To: <4A659D75.3050004@tuffmail.co.uk>
On Tue, Jul 21, 2009 at 11:50:29AM +0100, Alan Jenkins wrote:
> +struct block_device *bdcopy(struct block_device *bdev)
> +{
> + atomic_inc(&bdev->bd_inode->i_count);
> + return bdev;
> +}
> +
> +EXPORT_SYMBOL(bdcopy);
The function name doesn't make any sense. You don't copy anything
here, but you grab a reference to it. A better name would be bdgrab,
mirroing the names of functions like igrab. A kerneldoc comment
documenting it would also be very helpful.
Why do you export it? The swapfile code is not actually modular.
next prev parent reply other threads:[~2009-07-21 21:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 13:54 PM/hibernate swapfile regression Heiko Carstens
2009-07-14 16:21 ` Rafael J. Wysocki
2009-07-14 16:21 ` Rafael J. Wysocki
2009-07-15 21:24 ` Alan Jenkins
2009-07-15 21:24 ` Alan Jenkins
2009-07-17 13:08 ` Alan Jenkins
2009-07-17 13:08 ` Alan Jenkins
2009-07-20 13:24 ` Heiko Carstens
2009-07-20 13:24 ` Heiko Carstens
2009-07-21 10:50 ` Alan Jenkins
2009-07-21 13:41 ` Rafael J. Wysocki
2009-07-21 13:41 ` Rafael J. Wysocki
2009-07-21 20:57 ` Rafael J. Wysocki
2009-07-21 21:46 ` Johannes Weiner
2009-07-21 21:46 ` Johannes Weiner
2009-07-21 20:57 ` Rafael J. Wysocki
2009-07-21 21:55 ` Christoph Hellwig
2009-07-21 21:55 ` Christoph Hellwig [this message]
2009-07-25 21:58 ` Rafael J. Wysocki
2009-07-27 5:12 ` Christoph Hellwig
2009-07-27 5:12 ` Christoph Hellwig
2009-07-25 21:58 ` Rafael J. Wysocki
2009-07-21 10:50 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721215536.GA9502@infradead.org \
--to=hch@infradead.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=arnd@de.ibm.com \
--cc=hans@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.