All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 3/6] ocfs2: Initialize blocks allocated to local quota file
Date: Tue, 21 Jul 2009 15:20:37 -0700	[thread overview]
Message-ID: <20090721222037.GF19170@mail.oracle.com> (raw)
In-Reply-To: <1247673304-31080-4-git-send-email-jack@suse.cz>

On Wed, Jul 15, 2009 at 05:55:01PM +0200, Jan Kara wrote:
> +	handle = ocfs2_start_trans(OCFS2_SB(sb), 3);
> +	if (IS_ERR(handle)) {
> +		status = PTR_ERR(handle);
> +		mlog_errno(status);
> +		goto out;
> +	}

	Can we define the quota credit counts in fs/ocfs2/journal.h like
all of our other transaction constants?  I just realized how many raw
numbers there are in the quota c files.  Please define the _CREDITS
values appropriately and put them in journal.h with descriptions.  You
can do this as a separate patch at the end of the series.

Joel

-- 

"I think it would be a good idea."  
        - Mahatma Ghandi, when asked what he thought of Western
          civilization

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

  reply	other threads:[~2009-07-21 22:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 15:54 [Ocfs2-devel] [PATCH 0/6] Quota fixes for 2.6.31-rc4 Jan Kara
2009-07-15 15:54 ` [Ocfs2-devel] [PATCH 1/6] ocfs2: Make global quota files blocksize aligned Jan Kara
2009-07-21 21:54   ` Joel Becker
2009-07-15 15:55 ` [Ocfs2-devel] [PATCH 2/6] ocfs2: Mark buffer uptodate before calling ocfs2_journal_access_dq() Jan Kara
2009-07-15 15:55 ` [Ocfs2-devel] [PATCH 3/6] ocfs2: Initialize blocks allocated to local quota file Jan Kara
2009-07-21 22:20   ` Joel Becker [this message]
2009-07-21 22:52     ` Jan Kara
2009-07-15 15:55 ` [Ocfs2-devel] [PATCH 4/6] ocfs2: Zero out padding of on disk dquot structure Jan Kara
2009-07-15 15:55 ` [Ocfs2-devel] [PATCH 5/6] ocfs2: Fix initialization of blockcheck stats Jan Kara
2009-07-15 15:55 ` [Ocfs2-devel] [PATCH 6/6] ocfs2: Remove syncjiff field from quota info Jan Kara
2009-07-21 22:24   ` Joel Becker
2009-07-21 22:55     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721222037.GF19170@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.