From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: authenc - convert to ahash
Date: Wed, 22 Jul 2009 09:32:11 +0200 [thread overview]
Message-ID: <20090722073211.GI20288@secunet.com> (raw)
In-Reply-To: <20090722070259.GA29808@gondor.apana.org.au>
On Wed, Jul 22, 2009 at 03:02:59PM +0800, Herbert Xu wrote:
> On Tue, Jul 21, 2009 at 11:02:17AM +0200, Steffen Klassert wrote:
> >
> > + err = crypto_ahash_finup(ahreq);
> > + if (err == -EINPROGRESS)
> > + return;
>
> This is redundant. All completion functions must expect to be
> called with EINPROGRESS followed by the actual completion later.
I copied this from crypto_authenc_encrypt_done(), so this is probaply
redundant too. If so, I'd send a patch to remove the already existing
checks too and put the updated ahash convertion patch on top of it.
next prev parent reply other threads:[~2009-07-22 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 9:02 [PATCH v2] crypto: authenc - convert to ahash Steffen Klassert
2009-07-21 12:25 ` Steffen Klassert
2009-07-21 13:07 ` Herbert Xu
2009-07-21 13:23 ` Steffen Klassert
2009-07-23 10:23 ` Steffen Klassert
2009-07-24 7:23 ` Herbert Xu
2009-07-24 8:32 ` Steffen Klassert
2009-07-22 7:02 ` Herbert Xu
2009-07-22 7:32 ` Steffen Klassert [this message]
2009-07-22 7:52 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090722073211.GI20288@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.