From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 22 Jul 2009 09:44:50 +0200
Subject: [U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea
In-Reply-To: <20090722072745.B79FF832E416@gemini.denx.de>
References: <1248182100-15318-1-git-send-email-sr@denx.de>
	<20090722072745.B79FF832E416@gemini.denx.de>
Message-ID: <200907220944.50403.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 22 July 2009 09:27:45 Wolfgang Denk wrote:
> > -#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	6	/* 24C02 requires 5ms
> > delay */ #define CONFIG_SYS_I2C_EEPROM_ADDR	0x52	/* I2C boot EEPROM
> > (24C02BN)	*/ #define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1	/* Bytes of
> > address		*/ +#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
> > +#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	10
>
> The commit message does not mention the increased write delay. Is htis
> really needed? The (removed) comment says 5ms should be sufficient?

10ms is also used on many other AMCC eval boards. It's more defensive. But you 
are correct. I should have mentioned it in the commit message. I'll add it and 
resubmit.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================