All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	Trivial Patch Monkey <trivial@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: trivial comment fixes
Date: Wed, 22 Jul 2009 13:59:30 -0700	[thread overview]
Message-ID: <20090722135930.756e2ada.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200907170319.02997.rjw@sisk.pl>

On Fri, 17 Jul 2009 03:19:02 +0200 Rafael J. Wysocki wrote:

> On Thursday 16 July 2009, Wu Fengguang wrote:
> > CC: Rafael J. Wysocki <rjw@sisk.pl>
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> 
> Thanks for the patch, I'll add it to the suspend tree when I'm back home
> (probably on Monday).
> 
> Best,
> Rafael
> 
> 
> > ---
> >  kernel/power/snapshot.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- linux.orig/kernel/power/snapshot.c
> > +++ linux/kernel/power/snapshot.c
> > @@ -233,7 +233,7 @@ static void *chain_alloc(struct chain_al
> >  
> >  #define BM_END_OF_MAP	(~0UL)
> >  
> > -#define BM_BITS_PER_BLOCK	(PAGE_SIZE << 3)
> > +#define BM_BITS_PER_BLOCK	(PAGE_SIZE * BITS_PER_BYTE)
> >  
> >  struct bm_block {
> >  	struct list_head hook;	/* hook into a list of bitmap blocks */
> > @@ -275,7 +275,7 @@ static void memory_bm_free(struct memory
> >  
> >  /**
> >   *	create_bm_block_list - create a list of block bitmap objects
> > - *	@nr_blocks - number of blocks to allocate
> > + *	@pages - number of pages to track
> >   *	@list - list to put the allocated blocks into
> >   *	@ca - chain allocator to be used for allocating memory
> >   */

BTW:
kernel-doc uses @parameter:
and not         @parameter -

---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

  reply	other threads:[~2009-07-22 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 13:42 [PATCH] power: trivial comment fixes Wu Fengguang
2009-07-17  1:19 ` Rafael J. Wysocki
2009-07-22 20:59   ` Randy Dunlap [this message]
2009-07-22 21:16     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090722135930.756e2ada.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.