From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTfYA-0006Nq-JP for mharc-grub-devel@gnu.org; Wed, 22 Jul 2009 13:24:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTfY9-0006My-1g for grub-devel@gnu.org; Wed, 22 Jul 2009 13:24:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTfY4-0006Ks-CC for grub-devel@gnu.org; Wed, 22 Jul 2009 13:24:16 -0400 Received: from [199.232.76.173] (port=35172 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTfY4-0006Ki-5t for grub-devel@gnu.org; Wed, 22 Jul 2009 13:24:12 -0400 Received: from mx20.gnu.org ([199.232.41.8]:46137) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTfY3-0007A2-FK for grub-devel@gnu.org; Wed, 22 Jul 2009 13:24:11 -0400 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTfY2-0006Ie-KI for grub-devel@gnu.org; Wed, 22 Jul 2009 13:24:10 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MTeSG-00071s-Qm for grub-devel@gnu.org; Wed, 22 Jul 2009 18:14:09 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MTfY0-0002Jw-MX for grub-devel@gnu.org; Wed, 22 Jul 2009 19:24:08 +0200 Date: Wed, 22 Jul 2009 19:24:08 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090722172408.GE8706@thorin> References: <20090718184255.GG8867@thorin> <20090718192211.GN8867@thorin> <20090719100205.GQ11691@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090719100205.GQ11691@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix when installing on pationless but partionable medium X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2009 17:24:17 -0000 On Sun, Jul 19, 2009 at 11:02:05AM +0100, Colin Watson wrote: > On Sat, Jul 18, 2009 at 09:22:11PM +0200, Robert Millan wrote: > > On Sat, Jul 18, 2009 at 09:00:36PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > On Sat, Jul 18, 2009 at 8:42 PM, Robert Millan wrote: > > > > I'm not sure there's much we can do about this.  Using heuristics sounds like > > > > it will make the solution worse than the problem.  I don't care much about > > > > Microsoft filesystems, but I'd hate to see GRUB fail on a completely sane > > > > ext3 inside msdos label because it happened to look like FAT in raw disk at > > > > the same time. > > > > > > The approach proposed by Collin avoids such problems since correct > > > pc_partition_map is always detected as such. > > > > I haven't looked at the source code, but what he said is we can determine if > > an MBR is valid by checking the bootable flag, and this is not always so. > > If the bootable flag is neither 0 nor 0x80, then neither libparted nor > the Linux kernel will understand it as a DOS partition table. Is it > really all that helpful for GRUB to attempt to do so? No. Sorry, I miss-read what you said before. See my other mail. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."