From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTfrx-00058N-I1 for mharc-grub-devel@gnu.org; Wed, 22 Jul 2009 13:44:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTfrv-00057L-GF for grub-devel@gnu.org; Wed, 22 Jul 2009 13:44:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTfrs-00055l-2K for grub-devel@gnu.org; Wed, 22 Jul 2009 13:44:43 -0400 Received: from [199.232.76.173] (port=36311 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTfrr-00055f-Lw for grub-devel@gnu.org; Wed, 22 Jul 2009 13:44:39 -0400 Received: from aybabtu.com ([69.60.117.155]:47366) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTfrr-00045P-6p for grub-devel@gnu.org; Wed, 22 Jul 2009 13:44:39 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MTem4-0007AJ-DN for grub-devel@gnu.org; Wed, 22 Jul 2009 18:34:36 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MTfro-0002Ma-3Y for grub-devel@gnu.org; Wed, 22 Jul 2009 19:44:36 +0200 Date: Wed, 22 Jul 2009 19:44:36 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090722174436.GK8706@thorin> References: <1248196443.27068.86.camel@mj> <4A660CE9.6040104@gmail.com> <1248211910.18091.8.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] UUID support for UFS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2009 17:44:44 -0000 On Tue, Jul 21, 2009 at 11:45:59PM +0200, Vladimir 'phcoder' Serbinenko wrote: > This change would allow to produce a code which is cleaner, easier to > read and understand. However I'm opposed to modifying printf function > for it. Instead we could just define somewhere: > GRUB_PRIx32 "%x" > #ifdef LONG_SIZEOF == 8 > GRUB_PRIx64 "%lx" > #else > GRUB_PRIx64 "%llx" > #endif This is unnecessary. We defined the data as grub_uint32_t, so just dropping the 'l' and the `unsigned long' casts should do. As Pavel said, if we ever support a platform where sizeof(int) != 4, we have more serious problems to worry about. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."