All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] linux26: do not set CFLAGS_KERNEL to TARGET_CFLAGS
Date: Wed, 22 Jul 2009 23:24:15 +0200	[thread overview]
Message-ID: <20090722232415.1a437f3a@surf> (raw)
In-Reply-To: <20090722204437.752507781D@busybox.osuosl.org>

Le Wed, 22 Jul 2009 22:43:51 +0200,
Peter Korsgaard <jacmet@sunsite.dk> a ?crit :

> Using TARGET_CFLAGS breaks the kernel build for the arm platform. The
> result is a kernel that can not be booted. So simply do not fiddle
> with the CFLAGS on a kernel build and the kernel build system will do
> the right thing (TM).

I'm not using Buildroot to build kernels, so I'm not sure, but I think
that this commit might break the kernel build with external toolchain.
With external toolchain, the --sysroot option must be passed to allow
gcc to find the headers and libraries. And the --sysroot option is
precisely inside $(TARGET_CFLAGS).

But:
 1. I'm not sure it actually breaks the build, it's a pure supposition
    that will have to be verified ;
 2. We can add the necessary code in the kernel specific Makefile to
    handle that particular situation.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2009-07-22 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22 20:43 [Buildroot] [git commit] linux26: do not set CFLAGS_KERNEL to TARGET_CFLAGS Peter Korsgaard
2009-07-22 21:24 ` Thomas Petazzoni [this message]
2009-07-22 21:47   ` H Hartley Sweeten
2009-07-23  5:43   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090722232415.1a437f3a@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.