All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org, Jonathan McDowell <noodles@earth.li>,
	Tony Lindgren <tony@atomide.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	e3-hacking@earth.li, Arun KS <arunks@mistralsolutions.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel] [RFC] [PATCH 3/3] ASoC: add support for Amstrad E3 (Delta) machine
Date: Thu, 23 Jul 2009 09:57:38 +0100	[thread overview]
Message-ID: <20090723085738.GC5744@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200907222118.06396.jkrzyszt@tis.icnet.pl>

On Wed, Jul 22, 2009 at 09:18:05PM +0200, Janusz Krzysztofik wrote:

> After all, I am not sure what your preferences finally are. If you still think 
> that exporting gpio based jack state from ASoC framework over gpiolib sysfs 
> doesn't hurt and can be usefull, I'll remove the code from my driver and 
> provide a patch against sound/soc/soc-jack.c. But if you would rather prefere 
> exposing jack state in a more general, not gpio limited way instead, or 
> depend on input layer provided EVIOCGSW ioctl, as Dmitry suggested 
> (unfortunatelly, unlike generic ldattach, there is no utility ready for 
> use!), I'd rather keep this gpio_export() in my driver, let's say for 
> diagnostic purposes, at least until that different option is ready for use in 
> a convenient way.

Jack state is already exposed via the input layer by the ALSA jack core.
Reporting of GPIO state via gpio_export() would be additional to that
and would be purely for debug purposes, it would not be recommended for
use by userspace applications.

      reply	other threads:[~2009-07-23  8:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22  3:22 [RFC] [PATCH 3/3] ASoC: add support for Amstrad E3 (Delta) machine Janusz Krzysztofik
2009-07-22  3:22 ` Janusz Krzysztofik
2009-07-22 11:03 ` Mark Brown
2009-07-22 11:03   ` [alsa-devel] " Mark Brown
2009-07-22 11:39   ` Takashi Iwai
2009-07-22 12:19     ` Mark Brown
2009-07-22 12:19       ` [alsa-devel] " Mark Brown
2009-07-22 14:55       ` Janusz Krzysztofik
2009-07-22 14:55         ` [alsa-devel] " Janusz Krzysztofik
2009-07-22 14:53   ` Janusz Krzysztofik
2009-07-22 14:53     ` [alsa-devel] " Janusz Krzysztofik
2009-07-22 15:07     ` Mark Brown
2009-07-22 15:07       ` [alsa-devel] " Mark Brown
2009-07-22 19:18       ` Janusz Krzysztofik
2009-07-22 19:18         ` [alsa-devel] " Janusz Krzysztofik
2009-07-23  8:57         ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723085738.GC5744@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=arunks@mistralsolutions.com \
    --cc=e3-hacking@earth.li \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=noodles@earth.li \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tiwai@suse.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.