From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/7] mac80211: Replace {sw, hw}_scanning variables with a bitfield
Date: Thu, 23 Jul 2009 12:46:55 +0200 [thread overview]
Message-ID: <200907231246.56210.helmut.schaa@googlemail.com> (raw)
In-Reply-To: <1248345497.19121.22.camel@johannes.local>
Am Donnerstag, 23. Juli 2009 schrieb Johannes Berg:
> On Thu, 2009-07-23 at 12:14 +0200, Helmut Schaa wrote:
> > Use a bitfield to store the current scan mode instead of two boolean
> > variables {sw,hw}_scanning. This patch does not introduce functional
> > changes but allows us to enhance the scan flags later (for example
> > for background scanning).
>
> > + if (test_bit(SCAN_SW_SCANNING, &local->scanning))
>
> Do we actually need atomic bitops?
No (at least not yet). That's why I used __set_bit. test_bit seems to not
have a non-atomic equivalent. Or did you mean not to use *_bit functions
at all?
Helmut
next prev parent reply other threads:[~2009-07-23 10:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 10:13 [PATCH 0/7] implement background scan Helmut Schaa
2009-07-23 10:13 ` [PATCH 1/7] mac80211: refactor the scan code Helmut Schaa
2009-07-23 10:36 ` Johannes Berg
2009-07-23 10:13 ` [PATCH 2/7] mac80211: advance the state machine immediately if no delay is needed Helmut Schaa
2009-07-23 10:36 ` Johannes Berg
2009-07-23 10:13 ` [PATCH 3/7] mac80211: introduce a new scan state "decision" Helmut Schaa
2009-07-23 10:37 ` Johannes Berg
2009-07-23 10:14 ` [PATCH 4/7] mac80211: Replace {sw, hw}_scanning variables with a bitfield Helmut Schaa
2009-07-23 10:38 ` Johannes Berg
2009-07-23 10:46 ` Helmut Schaa [this message]
2009-07-23 10:48 ` Johannes Berg
2009-07-23 10:14 ` [PATCH 5/7] mac80211: implement basic background scanning Helmut Schaa
2009-07-23 10:39 ` Johannes Berg
2009-07-23 10:48 ` Helmut Schaa
2009-07-23 10:59 ` Johannes Berg
2009-07-23 11:18 ` [PATCH v2 " Helmut Schaa
2009-07-23 10:14 ` [PATCH 6/7] mac80211: rename scan_state to next_scan_state Helmut Schaa
2009-07-23 10:39 ` Johannes Berg
2009-07-23 10:14 ` [PATCH 7/7] cfg80211: increase scan result expire time Helmut Schaa
2009-07-23 10:39 ` Johannes Berg
2009-07-23 10:50 ` Helmut Schaa
2009-07-23 11:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907231246.56210.helmut.schaa@googlemail.com \
--to=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.