All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Froyd <froydnj@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: fix breakage of --extra-{cflags, ldflags}
Date: Thu, 23 Jul 2009 09:58:01 -0700	[thread overview]
Message-ID: <20090723165801.GK32566@codesourcery.com> (raw)
In-Reply-To: <1248349241-26029-1-git-send-email-froydnj@codesourcery.com>

On Thu, Jul 23, 2009 at 04:40:41AM -0700, Nathan Froyd wrote:
> Commit e3fc14c3a1a77a1cda669a3e16f1f6b82577e4ec broke the use of
> --extra-{cflags,ldflags} in the case where those flags were necessary
> for bits of configure to succeed.  For instance, if you did:
>
>   configure [...] --extra-cflags=-I/path/to/zlib/headers \
>     --extra-ldflags=-L/path/to/zlib/libraries
>
> prior to the above commit, the paths would go into CFLAGS and LDFLAGS
> for use by the rest of the configure tests.

I spoke too soon; it turns out that the use of CFLAGS in the zlib
configure test is a local patch we have to QEMU.  So this is not an
issue for upstream QEMU at the moment.

It does raise the question of how configure is supposed to find things
in non-standard locations, but since none of the other configure tests
seem to care about non-standard compilation scenarios (e.g. using
--extra-* to specify the location of the SASL libraries won't
work)...this is probably not worth addressing unless people feel it's
worthwhile for the sake of Truth and Beauty.

Sorry about the noise.

-Nathan

      parent reply	other threads:[~2009-07-23 16:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23 11:40 [Qemu-devel] [PATCH] configure: fix breakage of --extra-{cflags, ldflags} Nathan Froyd
2009-07-23 14:13 ` [Qemu-devel] " Jan Kiszka
     [not found]   ` <m3bpnb6041.fsf@neno.mitica>
2009-07-23 14:20     ` Nathan Froyd
     [not found]       ` <m33a8n5slq.fsf@neno.mitica>
2009-07-23 16:32         ` Jan Kiszka
2009-07-23 14:50     ` Jan Kiszka
2009-07-23 16:58 ` Nathan Froyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723165801.GK32566@codesourcery.com \
    --to=froydnj@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.