From: Stuart Brady <sdbrady@ntlworld.com>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.
Date: Thu, 23 Jul 2009 21:10:06 +0100 [thread overview]
Message-ID: <20090723201006.GA29483@miranda.arrow> (raw)
In-Reply-To: <5b31733c0907230208o7374ad68uf6e4438a5c5a41d5@mail.gmail.com>
+ dest = args[0];
+ src = args[1];
+ if (const_temps[src]) {
+ const_temps[dest] = 1;
+ dest_val = ~temp_values[src];
+ *opc_ptr = INDEX_op_movi_i32;
Hrm... is it really right to be setting *opc_ptr = INDEX_op_movi_i32
even for 64-bit ops? Applies to both 'not'[0] and the binary ops...
Cheers,
--
Stuart Brady
[0] BTW, the #ifdefs will need shuffling if other unary ops (e.g. neg)
are wanted... it's trivial, but I can't see a reason not to do it. :-)
next prev parent reply other threads:[~2009-07-23 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 14:37 [Qemu-devel] [PATCH] RFC: TCG constant propagation Filip Navara
2009-07-23 9:08 ` Filip Navara
2009-07-23 9:25 ` Laurent Desnogues
2009-07-23 9:30 ` Paul Brook
2009-07-23 9:49 ` Filip Navara
2009-07-23 20:10 ` Stuart Brady [this message]
2009-07-23 20:28 ` Filip Navara
2009-07-23 22:02 ` Daniel Jacobowitz
2009-08-05 8:13 ` Pablo Virolainen
2009-08-05 8:48 ` Filip Navara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723201006.GA29483@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=filip.navara@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.