All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC
Date: Thu, 23 Jul 2009 23:39:13 +0200	[thread overview]
Message-ID: <20090723213913.GD9480@game.jcrosoft.org> (raw)
In-Reply-To: <4A67F400.6070606@gmail.com>

On 22:24 Wed 22 Jul     , Ben Warren wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>>-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> >>>-OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
> >>>+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
> >>>+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
> >>> all:	$(obj).depend $(LIB)
> >>>diff --git a/cpu/arm920t/at91rm9200/ks8721.c b/cpu/arm920t/at91rm9200/ks8721.c
> >>>new file mode 100644
> >>>index 0000000..703e58c
> >>>--- /dev/null
> >>>+++ b/cpu/arm920t/at91rm9200/ks8721.c
> >>>@@ -0,0 +1,244 @@
> >>>+/*
> >>>+ * (C) Copyright 2006
> >>>+ * Author : Eric Benard (Eukrea Electromatique)
> >>>+ * based on dm9161.c which is :
> >>>+ * (C) Copyright 2003
> >>>+ * Author : Hamid Ikdoumi (Atmel)
> >>I'm not a fan of this implementation at all
> >>
> >>but as I've not yet finish the rm9200 cleanup
> >>I'll ack this ben what do you think?
> >>ben please note that the rm9200 cleanup will introduce a phylib support
> >Ben ping
> >
> >Best Regards,
> >J.
> This patch has many coding style violations that haven't been
> addressed, so it can't go in.  I"m not a fan of the piece-meal PHY
> implementation either, but realize that a real PHY lib isn't
> imminent, unless your rm2000 implementation is useful across
> architectures.
it will be a generic implementation
as we need it also for other soc and arch for our boards.

Best Regards,
J.

  parent reply	other threads:[~2009-07-23 21:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 13:24 [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC Eric Benard
2009-07-18 15:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 17:14   ` Eric Bénard
2009-07-18 17:44     ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 20:10       ` Eric Benard
2009-07-18 20:32         ` Wolfgang Denk
2009-07-18 22:09           ` [U-Boot] [PATCH v3] " Eric Benard
2009-07-23 22:27             ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 22:41               ` Wolfgang Denk
2009-07-23 22:55                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-22 21:51   ` [U-Boot] [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2009-07-23  5:24     ` Ben Warren
2009-07-23  5:55       ` Eric Bénard
2009-07-23  6:08         ` Ben Warren
2009-07-30 19:18           ` [U-Boot] [PATCH] " Eric Benard
2009-08-01  9:40             ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-01 15:40               ` Eric Bénard
2009-08-09 11:13               ` [U-Boot] [PATCH v5] " Eric Benard
2009-08-09 13:01                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-09 20:09                 ` Wolfgang Denk
2009-08-09 20:24                 ` Wolfgang Denk
2009-08-09 21:11                   ` Dirk Behme
2009-08-09 21:34                     ` Wolfgang Denk
2009-08-09 21:54                   ` [U-Boot] [PATCH v6] " Eric Benard
2009-08-09 11:15               ` [U-Boot] [PATCH v5] Cosmetic fix in MAKEALL as a separate patch Eric Benard
2009-08-09 20:20                 ` Wolfgang Denk
2009-07-23 21:39       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-07-23 21:43         ` [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723213913.GD9480@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.