All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Samuel <chris@csamuel.org>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Add supported kernel version check to mkfs.btrfs
Date: Fri, 24 Jul 2009 10:33:07 +1000	[thread overview]
Message-ID: <200907241033.07852.chris@csamuel.org> (raw)
In-Reply-To: <038wif2sqv.fsf@msgid.viggen.net>

On Fri, 24 Jul 2009 03:50:48 am Oystein Viggen wrote:

> Either way, I guess the RHEL developers could tell people a thing or two
> about the cleverness of assuming a kernel version equals a specific set
> of features and/or bugs.

I'm sure the RHEL developers would be able to change the #define in any tools 
they package to match the kernels they ship.

> WIBNI the btrfs kernel driver could export some kind of "btrfs_version"
> property that btrfs-tools could check instead?

Problem then is that you need to filesystem module inserted before you can 
make the filesystem, and usually that won't happen until you've mounted a 
filesystem of that type. Nice idea though!

> Then again, the need for shenanigans like this should pass quickly as
> the file system matures.

Indeed, but not that's not the case yet and we've had one person report issues 
this week that would have been caught by this. :-)

cheers,
Chris
-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

This email may come with a PGP signature as a file. Do not panic.
For more info see: http://en.wikipedia.org/wiki/OpenPGP

      reply	other threads:[~2009-07-24  0:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23  2:09 [PATCH] Add supported kernel version check to mkfs.btrfs Chris Samuel
2009-07-23 13:50 ` Roy Sigurd Karlsbakk
2009-07-23 17:50   ` Oystein Viggen
2009-07-24  0:33     ` Chris Samuel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907241033.07852.chris@csamuel.org \
    --to=chris@csamuel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.