All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: kvm: savevm is broken for me
Date: Fri, 24 Jul 2009 10:54:02 -0300	[thread overview]
Message-ID: <20090724105402.1ea81ad5@doriath> (raw)
In-Reply-To: <BEA72293-318B-41C5-8E4F-0029A38FB52E@suse.de>

On Fri, 24 Jul 2009 00:06:13 +0200
Alexander Graf <agraf@suse.de> wrote:

> On 23.07.2009, at 23:58, Luiz Capitulino wrote:
> 
> >
> > Hi there,
> >
> > If I try to 'savevm' with latest Anthony's tree (HEAD
> > 6f725c139ae975646c44ace77bf796318a5783da) QEMU will hang and I know
> > it's not saving anything because vmstat shows no disk activity (which
> > is the opposite behavior of when 'savevm' works).
> >
> > According to 'git bisect' the week's winner is:
> >
> > """
> > commit bd8367761236cd5c435598aeb2f1b8240c09b059
> > Author: Alexander Graf <agraf@suse.de>
> > Date:   Fri Jul 17 13:51:48 2009 +0200
> >
> >    Fake dirty loggin when it's not there
> > """
> >
> > Indeed, reverting this makes 'savevm' work for me.
> 
> 
> Yikes. I have no idea why, but just revert the patch :-). I don't  
> really need it anymore since we now have dirty logging in PPC.
> 
> Maybe it's the if (is dirty logging really enabled?) in the beginning?  

 Yes, it's the if. I have removed it and savevm works.

 Can you submit the fix please?

  reply	other threads:[~2009-07-24 13:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23 21:58 [Qemu-devel] kvm: savevm is broken for me Luiz Capitulino
2009-07-23 22:06 ` [Qemu-devel] " Alexander Graf
2009-07-24 13:54   ` Luiz Capitulino [this message]
2009-07-24 14:18     ` Alexander Graf
2009-07-24 14:20       ` Luiz Capitulino
2009-07-24 14:27         ` Alexander Graf
2009-07-24 19:42           ` Glauber Costa
2009-07-24 19:45             ` Alexander Graf
2009-07-24 20:09               ` Glauber Costa
2009-07-24 22:01                 ` Alexander Graf
2009-07-27 16:46                   ` Glauber Costa
2009-07-27 16:41                     ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090724105402.1ea81ad5@doriath \
    --to=lcapitulino@redhat.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.