From: Stephen Hemminger <shemminger@vyatta.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Linux Containers <containers@lists.osdl.org>,
Sachin Sant <sachinp@in.ibm.com>, netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
matthltc@us.ibm.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] veth: don't free priv->status until dev->destructor (v2)
Date: Fri, 24 Jul 2009 12:46:14 -0700 [thread overview]
Message-ID: <20090724124614.6acc5054@nehalam> (raw)
In-Reply-To: <20090626162418.GA24828@us.ibm.com>
On Fri, 26 Jun 2009 11:24:18 -0500
"Serge E. Hallyn" <serue@us.ibm.com> wrote:
> Based on the commit msg on ae0e8e82205c903978a79ebf5e31c670b61fa5b4, it looks
> ether_setup(dev);
> @@ -306,7 +320,7 @@ static void veth_setup(struct net_device *dev)
> dev->netdev_ops = &veth_netdev_ops;
> dev->ethtool_ops = &veth_ethtool_ops;
> dev->features |= NETIF_F_LLTX;
> - dev->destructor = free_netdev;
> + dev->destructor = veth_dev_free;
>
This is still going to oops if sysfs statistics referenced
after module unload because module is unloaded (code is gone)
and veth_dev_free no longer exists.
I'll respin the original patch (using free_netdev) and fix
the statistics complaint.
next prev parent reply other threads:[~2009-07-24 19:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 16:24 [PATCH 1/1] veth: don't free priv->status until dev->destructor (v2) Serge E. Hallyn
2009-06-26 16:24 ` Serge E. Hallyn
2009-07-15 15:50 ` David Miller
2009-07-20 21:25 ` Stephen Hemminger
2009-07-22 15:55 ` Serge E. Hallyn
2009-07-24 19:46 ` Stephen Hemminger [this message]
2009-08-05 6:40 ` Eric W. Biederman
2009-08-05 17:10 ` Stephen Hemminger
2009-08-05 17:10 ` Stephen Hemminger
2009-08-05 22:43 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090724124614.6acc5054@nehalam \
--to=shemminger@vyatta.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sachinp@in.ibm.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.