All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Trevor Pace <tr212206@dal.ca>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removed useless retval variables in usb-serial.c
Date: Fri, 24 Jul 2009 12:16:33 -0700	[thread overview]
Message-ID: <20090724191633.GA28619@kroah.com> (raw)
In-Reply-To: <200907241853.17877.oliver@neukum.org>

On Fri, Jul 24, 2009 at 06:53:17PM +0200, Oliver Neukum wrote:
> Am Freitag, 24. Juli 2009 17:48:03 schrieb Trevor Pace:
> > Removed useless return value variables.
> >
> > Signed-off By: Trevor Pace <trevor.pace@dal.ca>
> 
> These changes are a bad idea. They'll bite us in the ass as soon as we
> change locking or need to do more cleanups. The preferred form of
> error handling is
> 
> r = op()
> if (r < 0)
> 	goto error_exit;
> 
> I suggest that you don't apply them.

I agree with you, and will not be applying them.

thanks,

greg k-h

  reply	other threads:[~2009-07-24 19:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 15:48 [PATCH] Removed useless retval variables in usb-serial.c Trevor Pace
2009-07-24 16:29 ` Sergei Shtylyov
2009-07-24 17:06   ` Trevor Pace
2009-07-24 18:29     ` Greg KH
2009-07-24 16:53 ` Oliver Neukum
2009-07-24 19:16   ` Greg KH [this message]
2009-07-24 17:34 ` Greg KH
2009-07-24 18:02   ` Joe Perches
2009-07-24 18:12     ` Greg KH
     [not found]   ` <bad58e960907241047o7558a715u6a36535f2496c49d@mail.gmail.com>
2009-07-24 19:22     ` Fwd: " Trevor Pace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090724191633.GA28619@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=tr212206@dal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.