All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org
Subject: [PATCH 2/5] git-p4 stream: do not pass branchPrefixes so much
Date: Sat, 25 Jul 2009 10:24:16 -0400	[thread overview]
Message-ID: <20090725142416.GC3841@arf.padd.com> (raw)
In-Reply-To: <20090725142329.GA3841@arf.padd.com>

Just set it in self when commit starts and use it everywhere.
This makes the code a bit cleaner, but no functional change

Signed-off-by: Pete Wyckoff <pw@padd.com>
---
 contrib/fast-import/git-p4 |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 70fa403..3a52254 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -953,11 +953,11 @@ class P4Sync(Command):
     # output one file from the P4 stream
     # - helper for streamP4Files
 
-    def streamOneP4File(self, file, contents, branchPrefixes):
+    def streamOneP4File(self, file, contents):
         if verbose:
             sys.stderr.write("%s\n" %  file["depotFile"])
 
-        relPath = self.stripRepoPath(file['depotFile'], branchPrefixes)
+        relPath = self.stripRepoPath(file['depotFile'], self.branchPrefixes)
 
         mode = "644"
         if isP4Exec(file["type"]):
@@ -993,16 +993,16 @@ class P4Sync(Command):
             self.gitStream.write(d)
         self.gitStream.write("\n")
 
-    def streamOneP4Deletion(self, file, branchPrefixes):
+    def streamOneP4Deletion(self, file):
         if verbose:
             sys.stderr.write("delete %s\n" %  file["path"])
 
-        relPath = self.stripRepoPath(file['path'], branchPrefixes)
+        relPath = self.stripRepoPath(file['path'], self.branchPrefixes)
 
         self.gitStream.write("D %s\n" % relPath)
 
     # Stream directly from "p4 files" into "git fast-import"
-    def streamP4Files(self, files, branchPrefixes):
+    def streamP4Files(self, files):
         filesForCommit = []
         filesToRead = []
         filesToDelete = []
@@ -1026,7 +1026,7 @@ class P4Sync(Command):
 
         # deleted files...
         for f in filesToDelete:
-            self.streamOneP4Deletion(f, branchPrefixes)
+            self.streamOneP4Deletion(f)
 
         if len(filesToRead) > 0:
             stdin_file = tempfile.TemporaryFile(prefix='p4-stdin', mode='w+b')
@@ -1058,7 +1058,7 @@ class P4Sync(Command):
                             continue
 
 
-                        self.streamOneP4File(file,contents,branchPrefixes)
+                        self.streamOneP4File(file, contents)
                         file = {}
                         contents = []
                         have_file_info = False
@@ -1078,7 +1078,7 @@ class P4Sync(Command):
             # do the last chunk
 
             if file.has_key('depotFile'):
-                self.streamOneP4File(file,contents,branchPrefixes)
+                self.streamOneP4File(file,contents)
 
             exitCode = p4.wait()
             if exitCode != 0:
@@ -1088,6 +1088,7 @@ class P4Sync(Command):
     def commit(self, details, files, branch, branchPrefixes, parent = ""):
         epoch = details["time"]
         author = details["user"]
+	self.branchPrefixes = branchPrefixes
 
         if self.verbose:
             print "commit into %s" % branch
@@ -1127,7 +1128,7 @@ class P4Sync(Command):
                 print "parent %s" % parent
             self.gitStream.write("from %s\n" % parent)
 
-        self.streamP4Files(new_files,branchPrefixes)
+        self.streamP4Files(new_files)
         self.gitStream.write("\n")
 
         change = int(details["change"])
-- 
1.6.2.5

  parent reply	other threads:[~2009-07-25 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-11  8:31 [PATCH/RFC v2] git-p4: stream from perforce to speed up clones Luke Diamand
2009-07-25 14:23 ` Pete Wyckoff
2009-07-25 14:23   ` [PATCH 1/5] git-p4 stream: remove unused function Pete Wyckoff
2009-07-25 14:24   ` Pete Wyckoff [this message]
2009-07-25 14:24   ` [PATCH 3/5] git-p4 stream: show relative path in debug messages Pete Wyckoff
2009-07-25 14:24   ` [PATCH 4/5] git-p4 stream: check apple file type Pete Wyckoff
2009-07-25 14:25   ` [PATCH 5/5] git-p4 stream: use existing p4CmdList with callback Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090725142416.GC3841@arf.padd.com \
    --to=pw@padd.com \
    --cc=git@vger.kernel.org \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.