From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MUkEm-0000Wk-Ra for mharc-grub-devel@gnu.org; Sat, 25 Jul 2009 12:36:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUkEl-0000WK-Pr for grub-devel@gnu.org; Sat, 25 Jul 2009 12:36:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUkEh-0000UZ-97 for grub-devel@gnu.org; Sat, 25 Jul 2009 12:36:43 -0400 Received: from [199.232.76.173] (port=42662 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUkEh-0000UV-5h for grub-devel@gnu.org; Sat, 25 Jul 2009 12:36:39 -0400 Received: from aybabtu.com ([69.60.117.155]:36818) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MUkEg-0005ux-Pk for grub-devel@gnu.org; Sat, 25 Jul 2009 12:36:38 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MUj8d-0002GW-GU for grub-devel@gnu.org; Sat, 25 Jul 2009 17:26:19 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MUkEe-0003J2-7Q for grub-devel@gnu.org; Sat, 25 Jul 2009 18:36:36 +0200 Date: Sat, 25 Jul 2009 18:36:36 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090725163636.GL12326@thorin> References: <1248454704.3510.67.camel@fz.local> <1248463471.3510.77.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1248463471.3510.77.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] fix an infinite loop with a corrupted pc partition table X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2009 16:36:44 -0000 On Fri, Jul 24, 2009 at 09:24:31PM +0200, Felix Zielcke wrote: > + loop = 0; > + while (loop < 100000) > [...] > + if (loop == 100000) > + return grub_error (GRUB_ERR_BAD_PART_TABLE, "Corrupted partition table found."); What does this 100000 represent? It looks like heuristic, but I'm missing some context (I'm not familiar with extended partition layout). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."