From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MUkN1-0004LO-0i for mharc-grub-devel@gnu.org; Sat, 25 Jul 2009 12:45:15 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUkMy-0004L5-UE for grub-devel@gnu.org; Sat, 25 Jul 2009 12:45:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUkMu-0004KH-Cz for grub-devel@gnu.org; Sat, 25 Jul 2009 12:45:12 -0400 Received: from [199.232.76.173] (port=36392 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUkMu-0004KE-8V for grub-devel@gnu.org; Sat, 25 Jul 2009 12:45:08 -0400 Received: from aybabtu.com ([69.60.117.155]:38986) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MUkMt-0007b6-Oo for grub-devel@gnu.org; Sat, 25 Jul 2009 12:45:07 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MUjGp-0002HF-TA for grub-devel@gnu.org; Sat, 25 Jul 2009 17:34:48 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MUkMq-0003KN-SK for grub-devel@gnu.org; Sat, 25 Jul 2009 18:45:04 +0200 Date: Sat, 25 Jul 2009 18:45:04 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090725164504.GP12326@thorin> References: <1248478502.3510.96.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1248478502.3510.96.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1] X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2009 16:45:13 -0000 On Sat, Jul 25, 2009 at 01:35:02AM +0200, Felix Zielcke wrote: > Is this an acceptable fix? > Though I have the feeling this isn't a proper one. > > -------- Weitergeleitete Nachricht -------- > > Von: Bob Gilligan > > Reply-to: Bob Gilligan , 503344@bugs.debian.org > > An: submit@bugs.debian.org > > Betreff: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1 > > Datum: Fri, 24 Oct 2008 16:19:59 -0700 > > > > Package: grub-pc > > Version: 1.96+20080724-10 > > > > After installing grub-pc on an IBM x3250 with two 160 GB drives, with > > the root filesystem configured using mdadm for RAID-1, grub fails to > > boot, printing: > > > > Welcome to GRUB! > > > > error: unknown device fd1 > > Entering rescue mode ... > > grub rescue> ISTR we disabled floppy support completely in debian in order to avoid this kind of trouble (I would disable it in official GRUB as well, but I can already feel there'd be some opposition :-)). Anyway, my point is that floppies are too unreliable. We detect them when iterating even if they're not readable. Perhaps we could actually probe them for read during iteration to solve this. > > + grub_errno = GRUB_ERR_NONE; /* Used as error flag */ > > device_name = grub_file_get_device_name (name); > > if (grub_errno) > > return 0; This looks like a hack. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."