From: Frans Pop <elendil@planet.nl>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Manuel Lauss <manuel.lauss@googlemail.com>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH V2] au1xmmc: dev_pm_ops conversion
Date: Sat, 25 Jul 2009 20:18:58 +0200 [thread overview]
Message-ID: <200907252019.01266.elendil@planet.nl> (raw)
In-Reply-To: <20090725174449.GC14062@dtor-d630.eng.vmware.com>
On Saturday 25 July 2009, Dmitry Torokhov wrote:
> On Wed, Jul 22, 2009 at 05:18:39PM +0200, Manuel Lauss wrote:
> > Cc: Frans Pop <elendil@planet.nl>
> > Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> >
> > +
> > +static struct dev_pm_ops au1xmmc_pmops = {
> > + .resume = au1xmmc_resume,
> > + .suspend = au1xmmc_suspend,
> > +};
> > +
>
> Was suspend to disk tested? It requires freeze()/thaw().
Is that a regression introduced by this patch then? If so, many more of
the recent dev_pm_ops conversion patches would need to be revisited.
next prev parent reply other threads:[~2009-07-25 18:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 15:18 [PATCH V2] au1xmmc: dev_pm_ops conversion Manuel Lauss
2009-07-25 17:44 ` Dmitry Torokhov
2009-07-25 18:15 ` Manuel Lauss
2009-07-25 18:18 ` Frans Pop [this message]
2009-07-25 19:10 ` Dmitry Torokhov
2009-07-25 19:39 ` Rafael J. Wysocki
2009-07-25 20:21 ` Frans Pop
2009-07-25 20:38 ` Frans Pop
2009-07-25 21:06 ` Rafael J. Wysocki
2009-07-25 21:30 ` Frans Pop
2009-07-25 21:41 ` Dmitry Torokhov
2009-07-26 15:08 ` Mark Brown
2009-07-26 19:38 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2009-08-03 16:33 Albin Tonnerre
2009-08-03 19:23 ` Rafael J. Wysocki
2009-08-03 19:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907252019.01266.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.