From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 26 Jul 2009 12:42:13 -0400 Subject: [U-Boot] Add md5sum and sha1 commands... In-Reply-To: <200907252325.00174.rgetz@blackfin.uclinux.org> References: <200907251607.49314.rgetz@blackfin.uclinux.org> <200907252249.15951.vapier@gentoo.org> <200907252325.00174.rgetz@blackfin.uclinux.org> Message-ID: <200907261242.14607.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 25 July 2009 23:25:00 Robin Getz wrote: > On Sat 25 Jul 2009 22:49, Mike Frysinger pondered: > > On Saturday 25 July 2009 16:07:49 Robin Getz wrote: > > > +#ifdef CONFIG_CMD_MD5SUM > > > +U_BOOT_CMD( > > > + md5sum, 3, 1, do_md5sum, > > > + "compute MD5 message digest", > > > + "address count" > > > +); > > > +#endif > > > + > > > +#ifdef CONFIG_CMD_SHA1 > > > +U_BOOT_CMD( > > > + sha1, 3, 1, do_sha1, > > > + "compute SHA1 message digest", > > > + "address count" > > > +); > > > +#endif /* CONFIG_CMD_SHA1 */ > > > > there's no need for these to be at the bottom of the file. move the > > U_BOOT_CMD() into the releated #ifdef block. > > I'm just doing the same as all the other things in the same file (which > doesn't mean it is correct). What is the preferred style? ive been merging them to reduce #ifdef noise -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090726/4aa056bc/attachment.pgp