From: Daniel Jacobowitz <drow@false.org>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL, _IOLBF, 0) calls for Win32
Date: Mon, 27 Jul 2009 09:21:23 -0400 [thread overview]
Message-ID: <20090727132123.GA2428@caradoc.them.org> (raw)
In-Reply-To: <E1MVL9t-0001cm-94@lists.gnu.org>
On Mon, Jul 27, 2009 at 10:02:04AM +0000, Filip Navara wrote:
> On Win32 the setvbuf function requires the last parameter to be size between 2 and INT_MAX bytes, so the calls always failed. Since the whole point of the calls is to set line-buffered mode for the file handle and that's not supported on Win32 anyway, conditionally remove them.
Should they be unbuffered where _IOLBF is not supported, then? I
assume the line buffering was to make them more useful in event of a
crash.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-07-27 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 8:02 [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL, _IOLBF, 0) calls for Win32 Filip Navara
2009-07-27 13:21 ` Daniel Jacobowitz [this message]
2009-07-27 13:33 ` Filip Navara
2009-07-27 13:42 ` Daniel Jacobowitz
2009-07-27 14:25 ` Filip Navara
2009-07-27 14:32 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727132123.GA2428@caradoc.them.org \
--to=drow@false.org \
--cc=filip.navara@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.