From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Tim Gardner <timg@tpi.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] dell-laptop: Fix rfkill state setting
Date: Mon, 27 Jul 2009 15:53:49 +0100 [thread overview]
Message-ID: <20090727145349.GA7227@srcf.ucam.org> (raw)
In-Reply-To: <20090727144747.E7F4EF891B@sepang.rtg.net>
On Mon, Jul 27, 2009 at 08:47:47AM -0600, Tim Gardner wrote:
> Matthew,
>
> I think the rfkill state change logic is inverted. I've tried the original
> code on 3 different Dell models. Once 'rfkill block all' is run, then you
> can never unblock 'dell-wifi: Wireless LAN'. With this change you can get
> it unblocked, but you need to run 'rfkill unblock all' twice (which is
> likely an issue with rfkill).
Yes, there's clearly an issue of some sort here. I'll dig out a Dell and
test this, but it looks good.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-07-27 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 14:47 [PATCH] dell-laptop: Fix rfkill state setting Tim Gardner
2009-07-27 14:53 ` Matthew Garrett [this message]
2009-07-27 15:10 ` Johannes Berg
2009-07-27 15:19 ` Tim Gardner
2009-07-27 15:23 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727145349.GA7227@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=timg@tpi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.