Re: Dream in staging: separate Kconfig/Makefile into subdirectory

[Greg KH <greg@kroah.com>]

On Mon, Jul 20, 2009 at 12:35:32PM +0200, Pavel Machek wrote:
> Separate Kconfig/Makefile glue from dream into subdirectory. I plan to
> add few more drivers, and changing staging/Makefile each time sounds
> like inviting conflicts.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 300b83e..50f9ab0 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -133,11 +133,9 @@ source "drivers/staging/cpc-usb/Kconfig"
>  
>  source "drivers/staging/pata_rdc/Kconfig"
>  
> -source "drivers/staging/dream/smd/Kconfig"
> -
> -source "drivers/staging/dream/camera/Kconfig"
> -
>  source "drivers/staging/udlfb/Kconfig"
>  
> +source "drivers/staging/dream/Kconfig"
> +
>  endif # !STAGING_EXCLUDE_BUILD
>  endif # STAGING
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index 8d2e1c2..4fa2e07 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -1,7 +1,7 @@
>  # Makefile for staging directory
>  
>  # fix for build system bug...
> -obj-$(CONFIG_STAGING)		+= staging.o
> +obj-$(CONFIG_STAGING)		+= staging.o dream/

Ick, no, you shouldn't have to do this.

Please jump into the dream subdir based on a Kconfig option, don't go
there every single time.

Care to fix this up?

thanks,

greg k-h