From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] tools: python portability fixes Date: Tue, 28 Jul 2009 14:27:39 +0200 Message-ID: <200907281427.39344.Christoph.Egger@amd.com> References: <200907231558.12957.Christoph.Egger@amd.com> <200907280934.42860.Christoph.Egger@amd.com> <19054.52015.284098.943900@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19054.52015.284098.943900@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Tuesday 28 July 2009 11:55:59 Ian Jackson wrote: > Christoph Egger writes ("Re: [PATCH] tools: python portability fixes"): > > [stuff] > > Ah, I see. I don't think this is right. > > > When $(PYTHON) is python you get #!/usr/bin/python, > > This, in particularly, is wrong. But I don't have time right now to > investigate this properly. Can it wait until I'm back in the office > (this coming Monda) ? yes. > > > The get-path is a bash specific script which tries to get the information > > ^^^^^^^^^^^^^^^^^^^^ > While I'm here, though: you keep mentioning this as if there was > something wrong with this. I think having the Xen build system depend > on bash being installed is absolutely fine. On NetBSD, bash is a third-party package. scripts having #!/bin/bash fail with "/bin/bash: No such file or directory" The bourne shell (#!/bin/sh) is mighty enough to not require bashism. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632