From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MVtnh-00063D-Q5 for mharc-grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVtnd-00060t-Fx for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVtnX-0005vx-1M for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:28 -0400 Received: from [199.232.76.173] (port=40414 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVtnW-0005vp-Ns for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:22 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:47917 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVtnV-0007kI-5G for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:22 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MVtn6-0001DX-Hb for grub-devel@gnu.org; Tue, 28 Jul 2009 21:00:56 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MVqpA-00007j-IK for grub-devel@gnu.org; Tue, 28 Jul 2009 19:50:52 +0200 Date: Tue, 28 Jul 2009 19:50:52 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090728175052.GD32726@thorin> References: <1248392495.2661.208.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Fwd: [PATCH 1/2] Framebuffer split X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 21:01:30 -0000 On Mon, Jul 27, 2009 at 12:06:17AM +0200, Vladimir 'phcoder' Serbinenko wrote: > Removed parts which are purely moving code around (of course it will > be restored on commit). This is not a full review of the patch, just a quick overview. But I have a few comments: - The "fb" naming is confusing. "framebuffer" refers to a Linux API exported to userland on GNU/Linux, but it seems to be used for referring to the backend. I think it's better if we call it just that ("backend"). Or maybe "driver" but that doesn't apply well to vbe. - Some copyright years need updating (I noticed video_fb.h, but please review the other files as well). - It'd help if the patch could actually be split in standalone parts that can be committed separately. Maybe this is not possible, but at least for some parts of it, it probably is. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."