From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MVtnZ-0005yg-So for mharc-grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:25 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVtnW-0005vn-Kb for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVtnT-0005u2-1p for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:22 -0400 Received: from [199.232.76.173] (port=40409 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVtnS-0005tb-FB for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:18 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:47911 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVtnQ-0007jB-VB for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:17 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MVtn4-0001DX-8G for grub-devel@gnu.org; Tue, 28 Jul 2009 21:00:54 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MVrCj-00009Y-9F for grub-devel@gnu.org; Tue, 28 Jul 2009 20:15:13 +0200 Date: Tue, 28 Jul 2009 20:15:13 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090728181513.GK32726@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix CPUID documentation and return values X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 21:01:23 -0000 On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. CPUID command currently doesn't return a real grub_err_t and > errors aren't set which doesn't fit in grub2's design. > Addirionally "help cpuid" doesn't give really useful info. So for > future expandability and less confusion I propose the attached patch > partially based on original patch by Robert Millan Hi, I don't remember about this patch. I assume I wrote it in 2007 when merging cpuid support for first time. Any idea why it wasn't it committed back then? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."