From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MVtne-000612-8e for mharc-grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVtnZ-0005y0-Az for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVtnT-0005uA-7j for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:23 -0400 Received: from [199.232.76.173] (port=40408 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVtnS-0005tZ-E1 for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:18 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:47909 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVtnQ-0007iq-VE for grub-devel@gnu.org; Tue, 28 Jul 2009 17:01:17 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MVtn3-0001DX-DE for grub-devel@gnu.org; Tue, 28 Jul 2009 21:00:53 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MVrGi-0000AU-2R for grub-devel@gnu.org; Tue, 28 Jul 2009 20:19:20 +0200 Date: Tue, 28 Jul 2009 20:19:20 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090728181920.GM32726@thorin> References: <1244283931.3418.7.camel@fz.local> <1244339587.18630.8.camel@mj> <1244667896.8525.17.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1244667896.8525.17.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: 2273 lines in 170 files consists of only space and tabulators X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 21:01:26 -0000 On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote: > Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin: > > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote: > > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l > > > 2273 > > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 's/:.*//'|uniq|wc -l > > > 170 > > > > > > Anyone wants me to do > > > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//' > > > or does someone object? > > > [:blank:] doestn't contain these ^L chars. > > > > > > By the way `git diff --color' shows if you introduce such a line with > > > red, but strangely not when you remove one. > > > > Since we have linear development, it shouldn't be a problem for merging > > patches. Besides, "patch" can be told to ignore whitespace differences. > > > > However, I would prefer that we remove all trailing whitespace, not just > > that on empty lines. That is, remove "^" from the sed expression. > > Ok I just commited this. Do you mean removing all whitespace? I think you forgot to commit it. Though, I'd prefer if we don't do this in one megacommit. If we do it gradually, we avoid breaking patches. This makes work easier for branches and for distributors (which essentially operate as a branch). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."