From: Glauber Costa <glommer@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH] exit if we fail to initialize kvm
Date: Tue, 28 Jul 2009 18:28:52 -0300 [thread overview]
Message-ID: <20090728212852.GY4776@poweredge.glommer> (raw)
In-Reply-To: <A9392DF0-D82E-46CD-A36F-B9E70E390ABE@suse.de>
On Tue, Jul 28, 2009 at 11:15:19PM +0200, Alexander Graf wrote:
>
> On 28.07.2009, at 22:52, Glauber Costa <glommer@redhat.com> wrote:
>
>> Falling back to tcg has proven to be evil through time. The option is
>> to
>> do not try to act behind user's back, and quit the program completely
>> if
>> we fail to initialize kvm. Right now, the only way to run tcg from our
>> tree
>> becomes explicitly asking for it, with the -no-kvm option.
>
> Well, actually there's one little difference: I tell the user to use -
> no-kvm if he really wants cpu emulation.
>
> But simply failing is probably good enough.
With my patch, we won't fail if the user asked -no-kvm, because then we won't
even try to initialize kvm.
We only exit here, if we try, but fail
next prev parent reply other threads:[~2009-07-28 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 20:52 [PATCH] exit if we fail to initialize kvm Glauber Costa
2009-07-28 21:12 ` Alexander Graf
2009-07-28 21:15 ` Alexander Graf
2009-07-28 21:28 ` Glauber Costa [this message]
2009-07-28 21:38 ` Alexander Graf
2009-07-28 22:12 ` Alexander Graf
2009-07-29 10:17 ` Jan Kiszka
2009-07-29 11:49 ` Avi Kivity
2009-07-29 12:28 ` Alexander Graf
2009-07-29 12:47 ` Avi Kivity
2009-07-29 14:43 ` Jan Kiszka
2009-07-29 15:50 ` Glauber Costa
2009-07-29 15:52 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728212852.GY4776@poweredge.glommer \
--to=glommer@redhat.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.