All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Johan Herland <johan@herland.net>
Cc: <gitster@pobox.com>, <git@vger.kernel.org>,
	<johannes.schindelin@gmx.de>, <tavestbo@trolltech.com>,
	<git@drmicha.warpmail.net>, <chriscool@tuxfamily.org>,
	<spearce@spearce.org>
Subject: Re: [PATCHv3 5/8] Teach "-m <msg>" and "-F <file>" to "git notes edit"
Date: Wed, 29 Jul 2009 09:57:34 +0200	[thread overview]
Message-ID: <200907290957.36000.trast@student.ethz.ch> (raw)
In-Reply-To: <1248834326-31488-6-git-send-email-johan@herland.net>

Johan Herland wrote:
> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
[...]
> +cat > expect-m-and-F << EOF
> +commit 15023535574ded8b1a89052b32673f84cf9582b8
> +Author: A U Thor <author@example.com>
> +Date:   Thu Apr 7 15:16:13 2005 -0700
> +
> +    4th
> +
> +Notes:
> +    spam
> +    
> +    xyzzy
> +    
> +    foo

There's significant trailing whitespace here (in the lines between
spam, xyzzy and foo) that initially broke the test for me because I
use apply.whitespace=fix.  Can you guard the whitespace if it is
really important, with something like

sed 's/#$//' > expect <<EOF
whitespace:    #
EOF

Thanks!

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2009-07-29  8:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29  2:25 [PATCHv3 0/8] RESEND: git notes Johan Herland
2009-07-29  2:25 ` [PATCHv3 1/8] Introduce commit notes Johan Herland
2009-07-29  8:52   ` Alex Riesen
2009-07-29 16:40     ` Johannes Schindelin
2009-07-30  0:50       ` Johan Herland
2009-07-30  1:14         ` Johannes Schindelin
2009-07-30  0:42     ` Johan Herland
2009-07-29  2:25 ` [PATCHv3 2/8] Add a script to edit/inspect notes Johan Herland
2009-07-29  2:25 ` [PATCHv3 3/8] Speed up git notes lookup Johan Herland
2009-07-29  2:25 ` [PATCHv3 4/8] Add an expensive test for git-notes Johan Herland
2009-07-29  2:25 ` [PATCHv3 5/8] Teach "-m <msg>" and "-F <file>" to "git notes edit" Johan Herland
2009-07-29  7:57   ` Thomas Rast [this message]
2009-07-30  1:02     ` Johan Herland
2009-07-29  2:25 ` [PATCHv3 6/8] First draft of notes tree parser with support for fanout subtrees Johan Herland
2009-07-29 16:45   ` Johannes Schindelin
2009-07-30  0:18     ` Testing performance of the notes lookup code (Was: [PATCHv3 6/8] First draft of notes tree parser with support for fanout subtrees) Johan Herland
2009-08-01  2:36       ` [RFC] First draft of 256-tree structure for storing notes Johan Herland
2009-08-13  3:00         ` [RFC] Store subtree entries in the same hash map as the note entries Johan Herland
2009-08-26 10:31         ` [RFC] Use a 16-tree instead of a 256-tree for storing notes Johan Herland
2009-08-26 12:05           ` Alex Riesen
2009-08-26 12:56             ` Johan Herland
2009-08-26 13:24               ` Alex Riesen
2009-08-26 13:27                 ` Andreas Ericsson
2009-08-26 14:43                   ` Johan Herland
2009-08-27 11:56                   ` Johannes Schindelin
2009-07-29  2:25 ` [PATCHv3 7/8] fast-import: Add support for importing commit notes Johan Herland
2009-07-29 14:21   ` Shawn O. Pearce
2009-07-30  1:29     ` Johan Herland
2009-07-29  2:25 ` [PATCHv3 8/8] t3302-notes-index-expensive: Speed up create_repo() Johan Herland
2009-07-29 16:46   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907290957.36000.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=chriscool@tuxfamily.org \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johan@herland.net \
    --cc=johannes.schindelin@gmx.de \
    --cc=spearce@spearce.org \
    --cc=tavestbo@trolltech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.