From: Glauber Costa <glommer@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] simplify creation of kernel irqchip and pit
Date: Wed, 29 Jul 2009 10:50:00 -0300 [thread overview]
Message-ID: <20090729135000.GA4776@poweredge.glommer> (raw)
In-Reply-To: <4A703A34.2090900@redhat.com>
On Wed, Jul 29, 2009 at 03:01:56PM +0300, Avi Kivity wrote:
> On 07/24/2009 08:57 AM, Glauber Costa wrote:
>> Creation of those devices can be a lot simpler. In particular,
>> if we start by assuming they will be on, and disabling later if
>> anything fails (user request counts as failing here), we can remove
>> two variables that really serves no reason.
>>
>
> The patch introduces mixed indentation. Please stick with one style or
> another.
Are you willin go "apply" my patch that changes everything to four spaces?
If you are, I'm only resending things after that.
>
> --
> error compiling committee.c: too many arguments to function
>
next prev parent reply other threads:[~2009-07-29 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 5:57 [PATCH] simplify creation of kernel irqchip and pit Glauber Costa
2009-07-29 12:01 ` Avi Kivity
2009-07-29 13:50 ` Glauber Costa [this message]
2009-07-29 13:49 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729135000.GA4776@poweredge.glommer \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.