From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: dwalker@fifo99.com
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>
Subject: Re: [RFC][patch 02/12] remove clocksource inline functions
Date: Wed, 29 Jul 2009 16:44:11 +0200 [thread overview]
Message-ID: <20090729164411.6d7bd9f6@skybase> (raw)
In-Reply-To: <200907291415.n6TEFJkA019086@d06av05.portsmouth.uk.ibm.com>
On Wed, 29 Jul 2009 08:15:19 -0600
dwalker@fifo99.com wrote:
> > Remove clocksource_read, clocksource_enable and clocksource_disable
> > inline functions. No functional change.
> >
>
> Your still not really explaining this one, is this suppose to be
> cleaner? Or is this related to some other part of your clean up?
The only one of the three inline functions that is a bit more
complicated is clocksource_enable() because of the mult_orig logic. But
that goes away with a later patch. The function aren't accessors either,
they are used exclusively by the timekeeping code. In short, they are
useless, don't you think?
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next parent reply other threads:[~2009-07-29 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907291415.n6TEFJkA019086@d06av05.portsmouth.uk.ibm.com>
2009-07-29 14:44 ` Martin Schwidefsky [this message]
2009-07-29 14:57 ` [RFC][patch 02/12] remove clocksource inline functions Daniel Walker
[not found] <200907291457.n6TEvDAt003701@d06av06.portsmouth.uk.ibm.com>
2009-07-29 15:32 ` Martin Schwidefsky
2009-07-29 15:36 ` Will Newton
2009-07-29 16:27 ` Martin Schwidefsky
2009-07-29 16:44 ` Martin Schwidefsky
2009-07-30 12:21 ` Valdis.Kletnieks
2009-07-30 21:48 ` Christoph Hellwig
2009-07-31 11:50 ` Valdis.Kletnieks
2009-08-03 8:10 ` Martin Schwidefsky
2009-07-29 15:52 ` Daniel Walker
2009-07-29 16:37 ` Martin Schwidefsky
2009-07-29 13:41 [RFC][patch 00/12] clocksource / timekeeping rework V2 Martin Schwidefsky
2009-07-29 13:41 ` [RFC][patch 02/12] remove clocksource inline functions Martin Schwidefsky
2009-07-29 14:15 ` Daniel Walker
2009-07-30 21:46 ` Christoph Hellwig
2009-07-30 21:05 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729164411.6d7bd9f6@skybase \
--to=schwidefsky@de.ibm.com \
--cc=dwalker@fifo99.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.