From: Pavel Machek <pavel@ucw.cz>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: linux-input@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] [ARM] pxa/spitz: use GPIO matrix keypad driver
Date: Thu, 30 Jul 2009 11:43:07 +0200 [thread overview]
Message-ID: <20090730094307.GD1802@ucw.cz> (raw)
In-Reply-To: <4A7128F8.3010506@gmail.com>
On Thu 2009-07-30 13:00:40, Eric Miao wrote:
> Pavel Machek wrote:
> > On Mon 2009-07-20 19:41:54, Eric Miao wrote:
> >> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> >
> > Does this make some other driver obsolete? Should we disable the other
> > one or even remove it completely?
> >
>
> Yes, specifically the following two:
>
> drivers/input/keyboard/corgikbd.c
> drivers/input/keyboard/spitzkbd.c
>
> which I don't feel quite comfortable since they are referencing the PXA
> GPIO registers directly.
>
> However, marking obsolete might be more smooth for the moment.
Given that there are unused/unsuable after your patch is applied,
removing them from build system is probably good first step.
> >> static struct platform_device spitzkbd_device = {
> >> - .name = "spitz-keyboard",
> >> + .name = "matrix-keypad",
> >> .id = -1,
> >> + .dev = {
> >> + .platform_data = &spitzkbd_pdata,
> >> + },
> >> };
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2009-08-02 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 11:41 [PATCH] [ARM] pxa/spitz: use GPIO matrix keypad driver Eric Miao
2009-07-20 11:41 ` [PATCH] [ARM] pxa/corgi: " Eric Miao
2009-07-29 15:07 ` [PATCH] [ARM] pxa/spitz: " Pavel Machek
2009-07-30 5:00 ` Eric Miao
2009-07-30 9:43 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730094307.GD1802@ucw.cz \
--to=pavel@ucw.cz \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.