All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: consistent use of __u8 in scsi/scsi.h
Date: Thu, 30 Jul 2009 12:45:18 +0300	[thread overview]
Message-ID: <20090730094517.GC11381@redhat.com> (raw)
In-Reply-To: <4A71625C.8060707@panasas.com>

On Thu, Jul 30, 2009 at 12:05:32PM +0300, Boaz Harrosh wrote:
> On 07/29/2009 11:56 PM, Michael S. Tsirkin wrote:
> > On Wed, Jul 29, 2009 at 05:09:53PM +0300, Boaz Harrosh wrote:
> >> TODO:
> >> * Fix up Kernel headers by complying to check_headers
> > 
> > This is accomplished by applying the following on top
> > of my previous patch:
> > 
> 
> This is not enough. The same should be done to the other 3 
> include/scsi headers I mentioned and export them.

Right. Well, that's easy enough, isn't it?

Subject: scsi: export scsi_ioctl.h and sg.h headers

glibc uses scsi/sg.h and scsi/scsi_ioctl.h, so we need to
export these headers.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/scsi/Kbuild |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/scsi/Kbuild b/include/scsi/Kbuild
index 33b2750..a61932c 100644
--- a/include/scsi/Kbuild
+++ b/include/scsi/Kbuild
@@ -1,3 +1,5 @@
+header-y += sg.h
+header-y += scsi_ioctl.h
 header-y += scsi.h
 header-y += scsi_netlink.h
 header-y += scsi_netlink_fc.h
-- 
1.6.2.5


  reply	other threads:[~2009-07-30  9:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 11:11 [PATCH] scsi: consistent use of __u8 in scsi/scsi.h Michael S. Tsirkin
2009-07-29 11:11 ` Michael S. Tsirkin
2009-07-29 13:56 ` James Bottomley
2009-07-29 14:09   ` Boaz Harrosh
2009-07-29 20:56     ` Michael S. Tsirkin
2009-07-30  9:05       ` Boaz Harrosh
2009-07-30  9:45         ` Michael S. Tsirkin [this message]
2009-07-30  9:36     ` Michael S. Tsirkin
2009-07-30 13:16       ` Boaz Harrosh
2009-07-29 16:28   ` Sam Ravnborg
2009-07-29 16:37     ` James Bottomley
2009-07-29 19:29       ` Sam Ravnborg
2009-07-30  9:23       ` Boaz Harrosh
2009-07-30  9:34         ` Michael S. Tsirkin
2009-07-30 10:40           ` Sam Ravnborg
2009-07-29 21:11   ` Michael S. Tsirkin
2009-08-16 13:42   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090730094517.GC11381@redhat.com \
    --to=mst@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bharrosh@panasas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.