From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] xen: make (set|get)_xen_guest_handle available Date: Thu, 30 Jul 2009 13:55:33 +0200 Message-ID: <200907301355.33820.Christoph.Egger@amd.com> References: <270013.94181.qm@web56105.mail.re3.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <270013.94181.qm@web56105.mail.re3.yahoo.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Boris Derzhavets Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org Hi Boris, this is the history: NetBSD 2.0 got Xen 1.2 support (both Dom0 and DomU) NetBSD 3.0 got Xen 2 support, dropped Xen 1.2 support (both Dom0 and DomU) NetBSD 4.0 got Xen 3.0/3.1 support 32bit only, kept Xen 2 support (both Dom0 and DomU) NetBSD 5.0 got Xen 3.x support (both 32bit and 64bit), kept Xen 2 support (both Dom0 and DomU) NetBSD-current dropped Xen 2 support, about to move to new interface. Christoph On Thursday 30 July 2009 13:16:00 Boris Derzhavets wrote: > May the recent version of NetBSD run as PV guest ? > Sorry, for stupid question. > Boris. > > --- On Thu, 7/30/09, Christoph Egger wrote: > > From: Christoph Egger > Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle > available To: "Keir Fraser" > Cc: "xen-devel@lists.xensource.com" > Date: Thursday, July 30, 2009, 6:34 AM > > On Thursday 30 July 2009 12:14:04 Keir Fraser wrote: > > On 30/07/2009 10:12, "Christoph Egger" wrote: > > > Make (set|get)_xen_guest_handle() always available. > > > This avoids code snippets in the guest like this: > > > > > > #if __XEN_ITNERFACE_VERSION__ >= 0x00030201 > > > set_xen_guest_handle(hnd, val); > > > #else > > > hnd = val; > > > #endif > > > > Actually I don't see why you'd have code like this. *You*, the guest, > > gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- > > so ifdef'ing based on it in the guest is stupid. > > > > Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the > > guest handles, and then remove your ifdefs. Simple. > > The point is to keep backward compatibility. The patch makes Xen more > friendly with using the old non-structured guest handler if the user wants. > > NetBSD offers both way to build & run it with either using the old or new > interface. This allows a smooth migration. > > Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632