All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Wyart <damien.wyart@free.fr>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
	akpm@linux-foundation.org, jack@suse.cz,
	yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk,
	fweisbec@gmail.com, Alan.Brunelle@hp.com
Subject: Re: [PATCH 0/9] Per-bdi writeback flusher threads v13
Date: Fri, 31 Jul 2009 08:30:08 +0200	[thread overview]
Message-ID: <20090731063008.GA2796@brouette> (raw)
In-Reply-To: <1248989044-21605-1-git-send-email-jens.axboe@oracle.com>

Hello,

> Here's the 13th version of the writeback patches. Changes since v12:

> - Update to 2.6.31-rc4 ('ish, it's on top of current -git, but wil apply
>   to -rc4 as well).
> - Drop the last patch in the series, it was a questionable optimization
>   that needs to be tested and evaluated separately.

fs/sync.c has changed some time ago and I think your patch needs this
(which I had lazyly added by hand in v12 without telling):

--- a/fs/sync.c	2009-07-31 07:32:08.927926281 +0200
+++ b/fs/sync.c.new	2009-07-31 07:31:52.499801359 +0200
@@ -118,7 +118,7 @@ restart:
  */
 SYSCALL_DEFINE0(sync)
 {
-	wakeup_pdflush(0);
+	wakeup_flusher_threads(0);
 	sync_filesystems(0);
 	sync_filesystems(1);
 	if (unlikely(laptop_mode))



Best,

-- 
Damien Wyart

  parent reply	other threads:[~2009-07-31  6:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 21:23 [PATCH 0/9] Per-bdi writeback flusher threads v13 Jens Axboe
2009-07-30 21:23 ` [PATCH 1/9] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-08-06 21:35   ` Christoph Hellwig
2009-08-12 16:12     ` Jens Axboe
2009-08-12 16:18       ` Jens Axboe
2009-08-28 20:29       ` Christoph Hellwig
2009-07-30 21:23 ` [PATCH 2/9] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-08-05 16:35   ` Jan Kara
2009-08-06 21:44     ` Christoph Hellwig
2009-07-30 21:23 ` [PATCH 3/9] writeback: get rid of pdflush completely Jens Axboe
2009-07-30 21:23 ` [PATCH 4/9] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-07-30 21:24 ` [PATCH 5/9] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-08-05 19:55   ` Jan Kara
2009-08-06  7:05     ` Jens Axboe
2009-08-06 20:56       ` Jan Kara
2009-08-24 11:43         ` Jens Axboe
2009-08-24 12:36           ` Jan Kara
2009-08-24 14:09             ` Jens Axboe
2009-08-06 21:33   ` Christoph Hellwig
2009-07-30 21:24 ` [PATCH 6/9] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-08-05 19:57   ` Jan Kara
2009-08-06  7:03     ` Jens Axboe
2009-08-06 18:55       ` Jan Kara
2009-07-30 21:24 ` [PATCH 7/9] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-07-30 21:24 ` [PATCH 8/9] writeback: add name to backing_dev_info Jens Axboe
2009-07-30 21:24 ` [PATCH 9/9] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-07-31  6:30 ` Damien Wyart [this message]
2009-07-31  7:15   ` [PATCH 0/9] Per-bdi writeback flusher threads v13 Jens Axboe
2009-08-03 19:29     ` Damien Wyart
2009-08-03 20:28       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090731063008.GA2796@brouette \
    --to=damien.wyart@free.fr \
    --cc=Alan.Brunelle@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=david@fromorbit.com \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@rsk.demon.co.uk \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.