From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/4] Fix possible memory leak on SIM reading error.
Date: Fri, 31 Jul 2009 10:09:44 -0500 [thread overview]
Message-ID: <200907311009.45230.denkenz@gmail.com> (raw)
In-Reply-To: <1248941132-13206-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
Hi,
> This would also stall the SIM op queue if there's a read error for a record
> other than the first. The other solution would be "goto next;" (keep
> reading further records).
Patch has been applied.
This really shouldn't happen in practice, but if it does, we should also look
to see if the read callback functions don't cleanup or don't behave properly
as a result of an error mid-stream. It looks like at least sim_msisdn_read_cb
might be affected. Could you check?
Regards,
-Denis
next prev parent reply other threads:[~2009-07-31 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 8:05 [PATCH 3/4] Fix possible memory leak on SIM reading error Andrzej Zaborowski
2009-07-31 15:09 ` Denis Kenzior [this message]
2009-08-01 22:46 ` Andrzej Zaborowski
2009-08-03 17:46 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907311009.45230.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.