From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWuGM-00069S-9v for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 11:43:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuGK-00068Z-7X for grub-devel@gnu.org; Fri, 31 Jul 2009 11:43:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuGD-00066E-RB for grub-devel@gnu.org; Fri, 31 Jul 2009 11:43:14 -0400 Received: from [199.232.76.173] (port=37724 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuGD-000668-LZ for grub-devel@gnu.org; Fri, 31 Jul 2009 11:43:09 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:45892 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWuGD-0001jH-7v for grub-devel@gnu.org; Fri, 31 Jul 2009 11:43:09 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MWuGB-0000Oj-L0 for grub-devel@gnu.org; Fri, 31 Jul 2009 15:43:07 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MWuGA-0003pF-QZ for grub-devel@gnu.org; Fri, 31 Jul 2009 17:43:06 +0200 Date: Fri, 31 Jul 2009 17:43:06 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090731154306.GB14675@thorin> References: <20090718184255.GG8867@thorin> <20090718192211.GN8867@thorin> <20090722172258.GD8706@thorin> <20090728173329.GB32726@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix when installing on pationless but partionable medium X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 15:43:16 -0000 On Tue, Jul 28, 2009 at 11:42:07PM +0200, Vladimir 'phcoder' Serbinenko wrote: > diff --git a/ChangeLog b/ChangeLog > index 23c288e..74b9247 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,5 +1,10 @@ > 2009-07-28 Vladimir Serbinenko > > + * partmap/pc.c (pc_partition_map_iterate): Check that boot flags are > + valid. > + > +2009-07-28 Vladimir Serbinenko > + > * loader/i386/multiboot_helper.S (grub_multiboot_backward_relocator): > Clear direction flag before jumping to OS. > (grub_multiboot2_real_boot): Likewise. > diff --git a/partmap/pc.c b/partmap/pc.c > index 6f68ecf..6a2efd2 100644 > --- a/partmap/pc.c > +++ b/partmap/pc.c > @@ -121,6 +121,10 @@ pc_partition_map_iterate (grub_disk_t disk, > if (mbr.signature != grub_cpu_to_le16 (GRUB_PC_PARTITION_SIGNATURE)) > return grub_error (GRUB_ERR_BAD_PART_TABLE, "no signature"); > > + for (i = 0; i < 4; i++) > + if (mbr.entries[i].flag & 0x7f) > + return grub_error (GRUB_ERR_BAD_PART_TABLE, "bad boot flag"); > + > /* Analyze DOS partitions. */ > for (p.index = 0; p.index < 4; p.index++) > { Looks fine to me. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."