From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWuU9-0006sD-IU for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 11:57:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuU7-0006pH-W2 for grub-devel@gnu.org; Fri, 31 Jul 2009 11:57:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuU3-0006fq-DU for grub-devel@gnu.org; Fri, 31 Jul 2009 11:57:31 -0400 Received: from [199.232.76.173] (port=52559 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuU3-0006fn-6u for grub-devel@gnu.org; Fri, 31 Jul 2009 11:57:27 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:48618 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWuU2-00054b-B9 for grub-devel@gnu.org; Fri, 31 Jul 2009 11:57:26 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MWuTp-0000PV-UT for grub-devel@gnu.org; Fri, 31 Jul 2009 15:57:14 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MWuTo-0003tm-Uj for grub-devel@gnu.org; Fri, 31 Jul 2009 17:57:12 +0200 Date: Fri, 31 Jul 2009 17:57:12 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090731155712.GD14675@thorin> References: <4F38CAFF-C240-46FC-84BA-D3B96872B3E3@gmail.com> <1248388931.2661.155.camel@mj> <20090725162115.GG12326@thorin> <46548255-1D8F-48F0-BD33-B0C1A0D54CF4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46548255-1D8F-48F0-BD33-B0C1A0D54CF4@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH 2/2] Alias cls as clear X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 15:57:32 -0000 On Tue, Jul 28, 2009 at 10:58:55PM -0700, Joe Auricchio wrote: > > On 25 Jul, 2009, at 09:21 , Robert Millan wrote: >> On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote: >>> >>> >>> How's this? >> >> The ChangeLog entry is incomplete. It should be e.g.: >> >> * commands/minicmd.c (grub_mini_cmd_clear): New function. >> >> etc. See other entries as an example. > > Updated patch attached. Hi, The ChangeLog entry is incomplete, it should list the changes in GRUB_MOD_INIT(minicmd) and GRUB_MOD_FINI(minicmd) too. Btw, your mailer sends text attachments with Content-Type set to application/octet-stream. Please could you adjust it so that it sets it to the standard text/plain MIME type? Otherwise mail clients may fail to recognize it as text, which makes context reply difficult. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."