All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] coreutils: add TODO note about stripping the installed binaries
Date: Fri, 31 Jul 2009 15:58:27 +0200	[thread overview]
Message-ID: <20090731155827.71a41bd7@surf> (raw)
In-Reply-To: <871vnxugef.fsf@macbook.be.48ers.dk>

Le Fri, 31 Jul 2009 15:32:40 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :

> We should actually rework the strip stuff as it doesn't make much
> sense to both do strip at package install time and just before
> generating the file systems.
> 
> We would probably simplify stuff a bit to always use install /
> install-exec and only strip at the end if wanted.

Same thing for the installation of headers or documentation. We have
different cases :

 * Some packages do make install into the staging dir, and then
   carefully copy only what's needed to the target dir (excluding
   documentation and headers) ;

 * Some packages do make install into the target dir, then cleanup
   what's not needed, sometimes looking at BR2_HAVE_DEVFILS and
   BR2_HAVE_DOCUMENTATION, sometimes not ;

 * Some packages do make install into the target dir, and don't cleanup
   anything, waiting for the final global cleanup of the root
   filesystem done by target-finalize in the main Makefile.

I don't have a particularly strong opinion on this and the strip case.
Intuitively, I would say I find the solution of letting each package
handle its stripping and its installation properly to be the cleanest
solution (i.e no global final cleanup).

I know at least of one corner case that would defeat the global
stripping approach: binaries developed in OCaml. See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256900. Admittedly,
that's a corner case and I don't think we really care about it, but
that's a known drawback of the global approach: it's not possible to
make fine-grained exceptions (but is it a problem ? not sure).

Another advantage of the per-package approach is that simply doing
"make install" to the target space is sometimes too heavy for some
packages, that install some utility/test/config/sample applications
that we don't want on the target. Using a per-package approach would
probably encourage people to be more careful about what they install in
the target space.

To conclude: I think I have a preference for the per-package approach,
but I wouldn't complain too much if the global approach only is the one
we go with :-)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2009-07-31 13:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 13:02 [Buildroot] [pull request] Pull request for branch program-invocation-and-coreutils Thomas Petazzoni
2009-07-31 13:02 ` [Buildroot] [PATCH 1/3] Fix PROGRAM_INVOCATION handling with external toolchains Thomas Petazzoni
2009-07-31 13:30   ` Peter Korsgaard
2009-07-31 13:32     ` Thomas Petazzoni
2009-07-31 13:37       ` Peter Korsgaard
2009-07-31 13:02 ` [Buildroot] [PATCH 2/3] coreutils: bump version Thomas Petazzoni
2009-07-31 13:02 ` [Buildroot] [PATCH 3/3] coreutils: add TODO note about stripping the installed binaries Thomas Petazzoni
2009-07-31 13:32   ` Peter Korsgaard
2009-07-31 13:58     ` Thomas Petazzoni [this message]
2009-07-31 13:30 ` [Buildroot] [pull request] Pull request for branch program-invocation-and-coreutils Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090731155827.71a41bd7@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.