From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWuwQ-00015S-Es for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuwO-00012L-Go for grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuwJ-0000vJ-NN for grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:44 -0400 Received: from [199.232.76.173] (port=40457 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuwJ-0000uu-I1 for grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:39 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:35543 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWuwI-0003I8-LP for grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:38 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MWuwD-0000TX-4J for grub-devel@gnu.org; Fri, 31 Jul 2009 16:26:33 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MWuwC-0003yz-Eq for grub-devel@gnu.org; Fri, 31 Jul 2009 18:26:32 +0200 Date: Fri, 31 Jul 2009 18:26:32 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090731162632.GL14675@thorin> References: <20090728181513.GK32726@thorin> <20090731160748.GG14675@thorin> <1249057151.3635.6.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1249057151.3635.6.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix CPUID documentation and return values X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 16:26:44 -0000 On Fri, Jul 31, 2009 at 06:19:11PM +0200, Felix Zielcke wrote: > Am Freitag, den 31.07.2009, 18:07 +0200 schrieb Robert Millan: > > On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote: > > > > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > >> Hello. CPUID command currently doesn't return a real grub_err_t and > > > >> errors aren't set which doesn't fit in grub2's design. > > > >> Addirionally "help cpuid" doesn't give really useful info. So for > > > >> future expandability and less confusion I propose the attached patch > > > >> partially based on original patch by Robert Millan > > > > > > > > Hi, > > > > > > > > I don't remember about this patch. I assume I wrote it in 2007 when > > > > merging cpuid support for first time. > > > Yes, it is. > > > > Any idea why it wasn't it committed > > > > back then? > > > > > > > None. Yoshinori K Okuji approved it here: > > > http://lists.gnu.org/archive/html/grub-devel/2007-05/msg00148.html > > > > I vaguely recall having disabled it because there was some issue with > > scripting. Assuming it's working properly now, I have no objection with > > it. > > > > There was one. > if [ 0=1 ] ; then echo t ; else echo f ; fi > did print t but then also `error: false' > This is now fixed. But the cpuid CLI worked differently, IIRC -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."